Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Remove uppercase transformation for alerts' titles #10800

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

deborahniesz
Copy link
Contributor

@deborahniesz deborahniesz commented Dec 19, 2024

Jira Ticket

Deploy Preview

Description

override the text-transform: uppercase that comes out of the box for admonitions and replace it with text-transform: none

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses ruff format + ruff check)
  • Appropriate tests and docs have been updated

For more information about contributing, visit our community resources.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit 40e5201
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/67658c2d030a6b0008a89651
😎 Deploy Preview https://deploy-preview-10800.docs.greatexpectations.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@deborahniesz deborahniesz changed the title override the text-transform: uppercase that comes out of the box for … [DOCS] Remove uppercase transformation for alerts' titles Dec 19, 2024
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.16%. Comparing base (17c2383) to head (40e5201).
Report is 9 commits behind head on develop.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #10800      +/-   ##
===========================================
- Coverage    80.70%   80.16%   -0.55%     
===========================================
  Files          464      465       +1     
  Lines        40373    40449      +76     
===========================================
- Hits         32582    32424     -158     
- Misses        7791     8025     +234     
Flag Coverage Δ
3.10 69.99% <ø> (+<0.01%) ⬆️
3.10 aws_deps ?
3.10 clickhouse ?
3.11 69.98% <ø> (-0.01%) ⬇️
3.11 aws_deps ?
3.11 big ?
3.11 clickhouse ?
3.12 69.99% <ø> (+<0.01%) ⬆️
3.12 athena or openpyxl or pyarrow or project or sqlite or aws_creds 56.40% <ø> (-0.01%) ⬇️
3.12 aws_deps 46.23% <ø> (+0.01%) ⬆️
3.12 big 54.75% <ø> (-0.01%) ⬇️
3.12 bigquery ?
3.12 databricks 50.29% <ø> (+<0.01%) ⬆️
3.12 filesystem 62.70% <ø> (+0.01%) ⬆️
3.12 mssql ?
3.12 mysql 51.69% <ø> (+<0.01%) ⬆️
3.12 postgresql 54.35% <ø> (-0.08%) ⬇️
3.12 snowflake ?
3.12 spark ?
3.12 spark_connect 46.52% <ø> (+0.01%) ⬆️
3.12 trino 52.25% <ø> (+<0.01%) ⬆️
3.9 70.00% <ø> (-0.01%) ⬇️
3.9 athena or openpyxl or pyarrow or project or sqlite or aws_creds 56.40% <ø> (-0.01%) ⬇️
3.9 aws_deps 46.25% <ø> (+0.01%) ⬆️
3.9 big 54.77% <ø> (-0.01%) ⬇️
3.9 bigquery ?
3.9 clickhouse 43.14% <ø> (+0.01%) ⬆️
3.9 databricks 50.29% <ø> (+<0.01%) ⬆️
3.9 filesystem 62.70% <ø> (+0.01%) ⬆️
3.9 mssql 51.27% <ø> (+<0.01%) ⬆️
3.9 mysql 51.67% <ø> (+<0.01%) ⬆️
3.9 postgresql 54.33% <ø> (-0.08%) ⬇️
3.9 snowflake ?
3.9 spark 57.65% <ø> (-0.01%) ⬇️
3.9 spark_connect 46.53% <ø> (+0.01%) ⬆️
3.9 trino 52.23% <ø> (+<0.01%) ⬆️
cloud 0.00% <ø> (ø)
docs-basic 53.91% <ø> (-0.17%) ⬇️
docs-creds-needed ?
docs-spark 52.34% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@deborahniesz deborahniesz added this pull request to the merge queue Dec 20, 2024
Merged via the queue into develop with commit d78b52b Dec 20, 2024
65 checks passed
@deborahniesz deborahniesz deleted the DOC-918_remove_all_caps_for_admonitions branch December 20, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants